امتیازها
113
راهحلها
27
- محل سکونت
- England
- نوشتهها
- 26,276
- تاریخ ثبتنام
- ۱۳۹۹٫۰۴٫۰۶
- پسندها
- 3,286
- سن
- 29
- وب سایت
- xenforo.xyz
- نسخه PHP
- 7.3
- نسخه زنفورو
- xenforo 2.2
A minor change, I've seen this method is a bit unsafe to extend/override, it's easy to pass in an empty $tempHash
Doing so will update every attachment in the database (that's not going to be easy to reverse)
can we add a check on the tempHash on this method, something like:
Code:
I cant see a reason why you would ever need to pass in an empty $tempHash
Other than some silly addon developer making a...
Read more
Doing so will update every attachment in the database (that's not going to be easy to reverse)
can we add a check on the tempHash on this method, something like:
Code:
if(!$tempHash){throw new \InvalidArgumentException("No hash provided for attachment");}I cant see a reason why you would ever need to pass in an empty $tempHash
Other than some silly addon developer making a...
Read more